forgejo/routers/web/repo
Jason Song 375fd15fbf
Refactor indexer (#25174)
Refactor `modules/indexer` to make it more maintainable. And it can be
easier to support more features. I'm trying to solve some of issue
searching, this is a precursor to making functional changes.

Current supported engines and the index versions:

| engines | issues | code |
| - | - | - |
| db | Just a wrapper for database queries, doesn't need version | - |
| bleve | The version of index is **2** | The version of index is **6**
|
| elasticsearch | The old index has no version, will be treated as
version **0** in this PR | The version of index is **1** |
| meilisearch | The old index has no version, will be treated as version
**0** in this PR | - |


## Changes

### Split

Splited it into mutiple packages

```text
indexer
├── internal
│   ├── bleve
│   ├── db
│   ├── elasticsearch
│   └── meilisearch
├── code
│   ├── bleve
│   ├── elasticsearch
│   └── internal
└── issues
    ├── bleve
    ├── db
    ├── elasticsearch
    ├── internal
    └── meilisearch
```

- `indexer/interanal`: Internal shared package for indexer.
- `indexer/interanal/[engine]`: Internal shared package for each engine
(bleve/db/elasticsearch/meilisearch).
- `indexer/code`: Implementations for code indexer.
- `indexer/code/internal`: Internal shared package for code indexer.
- `indexer/code/[engine]`: Implementation via each engine for code
indexer.
- `indexer/issues`: Implementations for issues indexer.

### Deduplication

- Combine `Init/Ping/Close` for code indexer and issues indexer.
- ~Combine `issues.indexerHolder` and `code.wrappedIndexer` to
`internal.IndexHolder`.~ Remove it, use dummy indexer instead when the
indexer is not ready.
- Duplicate two copies of creating ES clients.
- Duplicate two copies of `indexerID()`.


### Enhancement

- [x] Support index version for elasticsearch issues indexer, the old
index without version will be treated as version 0.
- [x] Fix spell of `elastic_search/ElasticSearch`, it should be
`Elasticsearch`.
- [x] Improve versioning of ES index. We don't need `Aliases`:
- Gitea does't need aliases for "Zero Downtime" because it never delete
old indexes.
- The old code of issues indexer uses the orignal name to create issue
index, so it's tricky to convert it to an alias.
- [x] Support index version for meilisearch issues indexer, the old
index without version will be treated as version 0.
- [x] Do "ping" only when `Ping` has been called, don't ping
periodically and cache the status.
- [x] Support the context parameter whenever possible.
- [x] Fix outdated example config.
- [x] Give up the requeue logic of issues indexer: When indexing fails,
call Ping to check if it was caused by the engine being unavailable, and
only requeue the task if the engine is unavailable.
- It is fragile and tricky, could cause data losing (It did happen when
I was doing some tests for this PR). And it works for ES only.
- Just always requeue the failed task, if it caused by bad data, it's a
bug of Gitea which should be fixed.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
2023-06-23 12:37:56 +00:00
..
actions Add actor and status dropdowns to run list (#25118) 2023-06-21 04:25:14 +00:00
setting Support configuration variables on Gitea Actions (#24724) 2023-06-20 22:54:15 +00:00
activity.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment.go Fix all possible setting error related storages and added some tests (#23911) 2023-06-14 11:42:38 +08:00
blame.go Sort repo topic labels by name (#24123) 2023-04-14 15:29:05 -04:00
branch.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
cherry_pick.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
commit.go Pass 'not' to commit count (#24473) 2023-05-08 07:10:53 +00:00
compare.go Don't list root repository on compare page if pulls not allowed (#24183) 2023-04-19 11:16:46 -04:00
download.go Fix all possible setting error related storages and added some tests (#23911) 2023-06-14 11:42:38 +08:00
editor.go Fix blank dir message when uploading files from web editor (#25391) 2023-06-20 19:58:03 +00:00
editor_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
find.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
helper.go Add actor and status dropdowns to run list (#25118) 2023-06-21 04:25:14 +00:00
helper_test.go Add actor and status dropdowns to run list (#25118) 2023-06-21 04:25:14 +00:00
http.go Redesign Scoped Access Tokens (#24767) 2023-06-04 20:57:16 +02:00
http_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue.go Refactor indexer (#25174) 2023-06-23 12:37:56 +00:00
issue_content_history.go Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
issue_dependency.go Add API to manage issue dependencies (#17935) 2023-03-28 13:23:25 -04:00
issue_label.go Make label templates have consistent behavior and priority (#23749) 2023-04-10 16:44:02 +08:00
issue_label_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
issue_lock.go Fix improper HTMLURL usages in Go code (#22839) 2023-02-11 14:34:11 +08:00
issue_pin.go Followup to pinned Issues (#24945) 2023-05-30 15:26:51 +00:00
issue_stopwatch.go Speed up HasUserStopwatch & GetActiveStopwatch (#23051) 2023-02-27 13:46:00 -05:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Fix improper HTMLURL usages in Go code (#22839) 2023-02-11 14:34:11 +08:00
issue_watch.go Rewrite logger system (#24726) 2023-05-21 22:35:11 +00:00
lfs.go Introduce path Clean/Join helper functions (#23495) 2023-03-21 16:02:49 -04:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
middlewares.go Show outdated comments in files changed tab (#24936) 2023-06-21 16:08:12 +00:00
migrate.go Make repo migration cancelable and fix various bugs (#24605) 2023-05-11 08:25:46 +00:00
milestone.go Improve Gitea's web context, decouple "issue template" code into service package (#24590) 2023-05-09 01:30:14 +02:00
packages.go Use dynamic package type list (#22263) 2022-12-29 00:31:54 +01:00
patch.go Redirect to the commit page after applying patch (#23056) 2023-02-24 16:56:41 +00:00
projects.go Merge new project templates into one (#24985) 2023-05-31 08:50:18 +02:00
projects_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
pull.go Show outdated comments in files changed tab (#24936) 2023-06-21 16:08:12 +00:00
pull_review.go Show outdated comments in files changed tab (#24936) 2023-06-21 16:08:12 +00:00
release.go Add actor and status dropdowns to run list (#25118) 2023-06-21 04:25:14 +00:00
release_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
render.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Fix all possible setting error related storages and added some tests (#23911) 2023-06-14 11:42:38 +08:00
search.go Refactor indexer (#25174) 2023-06-23 12:37:56 +00:00
setting.go Hide 'Mirror Settings' when unneeded, improve hints (#24433) 2023-05-29 11:32:52 +00:00
setting_protected_branch.go Support for status check pattern (#24633) 2023-05-17 16:11:13 +08:00
settings_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00
tag.go Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
topic.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
treelist.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view.go Show if File is Executable (#25287) 2023-06-16 07:46:12 +02:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
webhook.go Fix Permission in API returned repository struct (#25388) 2023-06-22 13:08:08 +00:00
wiki.go Decouple the different contexts from each other (#24786) 2023-05-21 09:50:53 +08:00
wiki_test.go Refactor web package and context package (#25298) 2023-06-18 09:59:09 +02:00